Don't shade kotlinx-coroutines-core in Fabric .jar#26
Open
BlackBeltPanda wants to merge 1 commit intochasem-dev:mainfrom
Open
Don't shade kotlinx-coroutines-core in Fabric .jar#26BlackBeltPanda wants to merge 1 commit intochasem-dev:mainfrom
BlackBeltPanda wants to merge 1 commit intochasem-dev:mainfrom
Conversation
BlackBeltPanda
force-pushed
the
fix-mod-incompat
branch
from
577f3ab to
a40c403
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fabric Language Kotlin already provides coroutines. Shading them into the .jar creates compatibility issues with other mods that attempt to use methods from a newer Kotlin version if the server loads an older one from Cobblemon Extras. For example, if a mod migrates from
kotlinx.datetime.Clocktokotlin.time.Clock, that mod can fail to call the newPlatformImplementations.getSystemClock(), which doesn't exist in thePlatformImplementationsbundled with Cobblemon Extras.